feat: Move sponsorship from frontier #911
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fairax
approved these changes
May 3, 2023
| @@ -121,3 +162,137 @@ where | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| /// Bla bla bla Mr. Freeman | |||
| // #[cfg(feature = "debug-logging")] | ||
| // log::trace!(target: "sponsoring", "checking who will pay fee for {:?} {:?}", source, reason); |
There was a problem hiding this comment.
Это надо либо раскоментить либо удалить.
| origin: &T::CrossAccountId, | ||
| ) -> Result<CheckEvmTransaction<'a, E>, E> { | ||
| let who = &v.who; | ||
| let max_fee_per_gas = Some(v.transaction_fee_input()?.0); |
There was a problem hiding this comment.
Может лучше не оборачивать в Option, чтобы потом не делать unwrap?
И оставить let (max_fee_per_gas, _) = self.transaction_fee_input()?; как было.
| ) | ||
| .as_ref() | ||
| .map(pallet_evm::Pallet::<T>::account_basic_by_id) | ||
| .map(|v| v.0); |
There was a problem hiding this comment.
Nit: Дело вкуса, но мне больше нравится .map(|(v, _)| v);
| .map(|v| v.0); | ||
|
|
||
| let fee = max_fee_per_gas.unwrap().saturating_mul(v.transaction.gas_limit); | ||
| if let Some(sponsor) = sponsor.as_ref() { |
There was a problem hiding this comment.
Проверка if self.config.is_transactional || fee > U256::zero() {, которая есть в изначальном коде, здесь не нужна?
bugrazoid
force-pushed
the
feature/move_sponsorship_to_chain
branch
from
f0a75e4 to
02ae332
Compare
fairax
force-pushed
the
feature/move_sponsorship_to_chain
branch
from
02ae332 to
84ba084
Compare
fairax
force-pushed
the
feature/move_sponsorship_to_chain
branch
from
84ba084 to
257fe16
Compare
fairax
force-pushed
the
feature/move_sponsorship_to_chain
branch
from
257fe16 to
1613a8e
Compare
fairax
force-pushed
the
feature/move_sponsorship_to_chain
branch
from
1613a8e to
4c3b709
Compare
fairax
force-pushed
the
feature/move_sponsorship_to_chain
branch
from
4c3b709 to
78ef2a9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.